Adding the missing card brand icon

Hello @ZeroClocer! 👋

I would be happy to pass along your feedback and requests to our team. Can you tell me a little more about this:

In addition, while 1Password allows the user to enter the card brand (type), the decision as to which icon 1Password displays appears to be based on the BIN database built into 1Password, which is not always correct.

Are you able to give me an example of a situation that I can reproduce on my end where the credit icon doesn't correspond to the type of card selected so that I can file an issue for this?

I look forward to hearing from you.

-Dave

Hi @1P_Dave

For example, a card number like this: 6229480000000006

(This is a fake card number that conforms to the credit card number rules, there is no real card associated to this card number, so don't worry about security)

It looks like 1Password will recognize this card number as Discover, but it is actually a UnionPay card issued by Standard Chartered Bank in Hong Kong.

@ZeroClocer

Thank you for posting the example. I see that our developers do have an internal work item open to look into cards being misidentified in this way and I've added your report (and example) there. I'm sorry for the inconvenience.

I've also filed a feature request so that our product team can look into adding icons for more types of credit cards. 🙂

-Dave

ref: dev/core/core#3266
ref: PB-33061514

Hi @ZeroClover:

I know it's been a bit, but I just wanted to follow up with you and let you know that some improvements for recognizing Discover cards when they shouldn't have been are now available in the 1Password in the browser Beta:

1Password in the browser Beta Releases

While I can't share a specific date on when it will be available in the 1Password desktop apps as well, I'm hopeful it should be soon.

Thanks again for flagging this, and I appreciate your patience on this!

Jack