Feature idea: when creating ssh keys, consider option to auto add comment to end of public key

+1 to this - when creating a new key today in 1Password, I thought perhaps that adding an additional field to the object of email would perhaps append it as a comment in the public key. I also tested to see if the notes field would do it.

I think there's a few options here for implementation that would be useful (or a combination) - I do like your proposal above to suffix with the object name, but that means I now need to consider what the comment will be when naming the object.

I think a good option could be to have a dropdown select for

Public Key Comment
- Use account email (based on vault)
- Use SSH key item name (strip whitespace / replace with hyphen / maybe display warning that this is happening)
- Custom - text field that validates entry

I only say validates entry for comment because you're limited to 1023 characters... https://github.com/openssh/openssh-portable/blob/94eb6858efecc1b4f02d8a6bd35e149f55c814c8/ssh-keygen.c#L1507) - frankly if you're hitting that limit then need help and possibly a wiki

I went down a little bit of a rabbit hole here as well - ssh-keygen -c won't let you enter a comment longer than 1023 characters - you can enter 1024, but it won't let you press enter until you remove the last one. If you then vi your pub you can go absolutely wild and neither ssh nor ssh-agent will care, but ssh-add -L will only print 1023 characters.

Anyway

Agree though that comment options are needed, as there's no way to edit the public key to add one manually, despite it being an incredibly useful component.

Also 1Password strips the comment if you have one and import. That's not good - store my pub, don't modify it

++ on this. Just went through all the same motions of assumption - experimentation - failing - giving up.

I would also like to add my name to those requesting this feature.

I will note that authorized keys can be edited and that you can append a space and any text after the key which will be treated as a comment - but it's way more convenient, imo, to have the ability to have the comment in the public key such that it is copied along with the key.

I my preference as to how it's implemented:

1. A comment field on the SSH item
2. The ability to edit the text in the public key field (although this would allow an invalid public key if done incorrectly)
3. Just use the item name (as noted above then one must consider that it will be a public comment when choosing an item name)

+1 from me for this request. I do like the idea of having a Comment field available on each SSH item, which then gets automatically appended to the public key.

I just tested adding a "comment" text field to an SSH key item, and indeed, it properly exports as an addendum to the public key whether you use the Download feature or the Copy feature. Fantastic! (Even if it apparently took four years.)

Given the functionality relies on the user manually adding a magic text field, I strongly suggest documenting the behavior beyond this thread since it's otherwise more easter egg than feature, with near-zero discoverability. I'm sure some will stumble on it since the magic name isn't something esoteric, but still, even developer-types appreciate docs sometimes. This page looks like the right spot to add it:

https://developer.1password.com/docs/ssh/manage-keys/

A future refinement might be to include the comments field by default, preferably as part of the core field block, meaning a new key item would have a group of fields that includes public key, fingerprint, private key, key type, and comment. In this scenario, renaming the comment field to something like "public key comment" might also be a good way to clarify exactly what the value is used for.