Skip to main content
scottaw
March 13, 2023
Question

Git 2.40 breaks op-ssh-sign

  • March 13, 2023
  • 7 replies
  • 968 views

After upgrading to git 2.40 today, op-ssh-sign now thinks I'm passing flags that I am not passing:

Anyone else seeing this issue?

op_apple_universal_v2.14.0.pkg (Pkg)


1Password Version: 8.10.1
Extension Version: Not Provided
OS Version: Not Provided
Browser:_ Not Provided

7 replies

March 13, 2023

same as what i saw:

https://1password.community/discussion/comment/680105

my temporary solution was to remove git from homebrew and fallback to the Apple supplied version...

scottaw
scottawAuthor
March 13, 2023

yeah, I might have to do the same. 😞 Thank you. Glad we have verification at least.

March 14, 2023

I'm also seeing this after updating to Git v2.40.0. Looks like the issue stems from this https://github.com/git/git/commit/dce7b31126 to git.

I use the Homebrew version of git, so for the interim I downloaded the https://github.com/Homebrew/homebrew-core/blob/ddf8239732984ee89bc44cfcd63cde4cfec451b5/Formula/git.rb and installed that (brew unlink git && brew install ~/Downloads/git.rb). Back to normality until git v2.40.1 (hopefully!).

scottaw
scottawAuthor
March 14, 2023

Nice catch. And nice info on how to get the older git version in homebrew. I googled everything and couldn’t even find out how to get homebrew to show me what other formula were even available.

floris_1P
1Password Employee
1Password Employee
March 14, 2023

We're working on a fix for this. For now, what you can do as a workaround is comment out the gpg.ssh.program line in your .gitconfig and set SSH_AUTH_SOCK yourself:

On macOS:

export SSH_AUTH_SOCK=~/Library/Group\ Containers/2BUA8C4S2C.com.1password/t/agent.sock

If you want to use it with a GUI application, you can launch it from the terminal session which has SSH_AUTH_SOCK set, e.g.

open -a /Applications/Tower.app

We'll keep you posted for when the fix is out.

scottaw
scottawAuthor
March 15, 2023

Thanks for the super fast turnaround on the update today

March 20, 2023

For anyone else who might be running into this:

We've released a fix for the issue described above both on production and on the nightly channels. If you're running into issues with git 2.40, try updating the 1Password app!