Skip to main content
May 22, 2023
Question

Git commit signing fails with `error: failed to fill whole buffer`

  • May 22, 2023
  • 27 replies
  • 2855 views

I've updated to Git 2.40.1 and it seems that broke commit signing. Prepending GIT_TRACE=2 to git commit gives as last message:

20:09:00.367459 run-command.c:655 trace: run_command: op-ssh-sign -Y sign -n git -f /tmp/.git_signing_key_tmpe1dbw6 -U /tmp/.git_signing_buffer_tmp0t7i5W

and after working on it for a bit, this gives:
```
error: failed to fill whole buffer

fatal: failed to write commit object
```


1Password Version: 8.10.6
Extension Version: 2.10.0
OS Version: NixOS 23.05.20230520.3005f20
Browser:_ Brave

27 replies

floris_1P
1Password Employee
1Password Employee
June 12, 2023

Which versions of Git and OpenSSH are you using? git --version && ssh -V

June 12, 2023


git version 2.40.1
OpenSSH_9.3p1, OpenSSL 3.0.9 30 May 2023

floris_1P
1Password Employee
1Password Employee
June 12, 2023

And the error message you're getting with op-ssh-sign, is that error: failed to fill whole buffer as well?

June 12, 2023

Correct. op-ssh-sign gives that whole buffer error.

June 22, 2023

I get this occasionally with the VSCode Git integration, though if I try again after it fails it usually works. I don't use the Git CLI very much but I don't think I've had the issue there, but could be wrong.

I am on macOS Ventura with 1Password for Mac 8.10.7 (81007041).
Git version: 2.41.0
OpenSSH version: OpenSSH_9.0p1, LibreSSL 3.3.6

June 28, 2023

I am receiving the same error in the same situation. Is there a remedy for this problem yet?

July 18, 2023

Installing the latest version of 1Password fixed it for me!

I'm now running 1Password 8.10.8, Git 2.41.0 and OpenSSH_9.3p1, OpenSSL 3.0.9 30 May 2023

August 15, 2023

Still happening for me intermittently on 1Password for Mac 8.10.9 (81009046).

August 16, 2023

Same issue here, using 1Password for Mac 8.10.9, only when using the VSCode integration. Using the git CLI works fine.

Also worth noting that this was working and stopped "all of the sudden". The "all of the sudden" may have been related to me installing the 1P Extension for Safari, though uninstalling it didn't solve the issue.

August 18, 2023

One more thing I noticed. Disabling some of the steps of my pre-commit got it to work with the VSCode Integration, so may be a race condition or timeout when committing that way.