Skip to main content
March 13, 2023
Question

upgraded to git 2.40.0 on homebrew and 1Password quit signing, throws error

  • March 13, 2023
  • 19 replies
  • 1982 views

➜ .brew-file git:(main) ✗ git commit -a -m "update"
error: error: Found argument '-U' which wasn't expected, or isn't valid in this context

If you tried to supply `-U` as a value rather than a flag, use `-- -U`

USAGE:
op-ssh-sign [OPTIONS] -Y [--] [payload]

For more information try --help

fatal: failed to write commit object

NOTE: if i remove git from homebrew and use the Apple supplied git, it all works. But this means i'm running an older version of git for everything...


1Password Version: 1Password for Mac 8.10.1 (81001033)
Extension Version: 2.8.1
OS Version: macOS Ventura 13.2.1
Browser:_ Chrome 111.0.5563.64 (Official Build) (arm64)
Referrer: forum-search:https://1password.community/search?Search=git%202.40.0

19 replies

floris_1P
1Password Employee
1Password Employee
March 14, 2023

You can run git config --show-origin --get-all gpg.ssh.program to see where op-ssh-sign gets set. Make sure comment out or remove that line. Alternatively, if it's easier, you can also consider downgrading Git.

We have a fix for it ready, which will become available later today.

March 14, 2023

We have a fix for it ready, which will become available later today.

I can certainly wait until later today!

(But for what it's worth, git config --show-origin --get-all gpg.ssh.program returns no output. I don't think that it is mentioned in the docs for using op with ssh and git.)

March 14, 2023

@floris_1P I already have SSH_AUTH_SOCK set to $HOME/.1password/agent.sock, so I just commented out the [gpg "ssh"] section from my .gitconfig and everything worked just fine.

This makes me wonder -- is the [gpg "ssh"] section even necessary if SSH_AUTH_SOCK is already set? Put another way, is op-ssh-sign doing anything that I don't already get by having SSH_AUTH_SOCK set up?

March 14, 2023

@floris_1P How's that fix going? :)

March 14, 2023

It's already out for macOS:
https://releases.1password.com/mac/8.10/#changelog

Working for me with the original git config back in place and no extra env vars.

@floris_1P Thank you 🫡

March 14, 2023

awesome, just updated 1Password and reinstalled git 2.40.0 via brew, it seems to be working again... Thank you !!

March 15, 2023

Works for me as well - kudos to the support and dev team on a quick turnaround! Thanks all

scottaw
March 15, 2023

Yep, thanks for the super fast turnaround on this one.

March 20, 2023

Indeed, we have released a fix for this both on the production and on the nightly channels.