Skip to main content
June 10, 2023
Question

System crash caused by memory leak

  • June 10, 2023
  • 27 replies
  • 1247 views

Has anyone using the beta had their system just die on them due to "low memory"?

I found that 1Password was having a committed memory leak and was causing this on my system. Switching back to prod fixed the issue. Let me know if you guys are interested in debugging this issue


1Password Version: Not Provided
Extension Version: Not Provided
OS Version: Not Provided
Browser:_ Not Provided

27 replies

MikeT
1Password Employee
June 30, 2023

Thanks for listing your specs.
I'll take a look on how it reacts on Windows enterprise version and get back to you. Some of the recent regressions were only found on the Enterprise version.

June 30, 2023

I have checked the second system, a 5800x AM4 with 32 GB with Win11 Home, same Patch Level. It does not have the issue.
Here is another screenshot of the process with the issue:

If I suspend or kill the thread 26596 with the start Address "index.node!git_patch_owner" the issue will go away. At the first look, 1Password seems to run properly.
There is an open support call with ID #YYF-91118-712. I send everything via mail.

MikeT
1Password Employee
June 30, 2023

Hi @aro148,

Just confirmed it is continuously increasing in PF count on the W11 enterprise side.

I'll file an issue and we'll get that fixed.

ref: dev/core/core#22700

July 3, 2023

As a developer, I would appreciate it if you could share the cause of the high Page Fault Count associated with Win11 Enterprise.

July 3, 2023

Hi,
I am seeing that in Windows 10 Pro also

MikeT
1Password Employee
July 6, 2023

Hi folks,

The page fault issue should now be greatly improved with the latest nightly build, 1Password for Windows 8.10.9 (81009021).

@aro148, I've asked for more details that we can share. My basic understanding is that it was due to how we were setting memory protection on our processes, which has its own challenges on specific Windows versions as well as domain/user types. It was stuck in a loop on business/enterprise versions after we were updating our internal Windows libraries in the last update.

July 7, 2023

Hi @MikeT ,
thank you very much for this feedback and the explanation.

I confirm with the latest nightly build the Page Fault count is a lot more under control.
There still is some after some time and usage but clearly it is much much better.

Also, 1P desktop use much less CPU cycles (even at rest) than before (it was quite noticeable with the last version).
In my opinion, the loop was the culprit in both cases.

So, a great improvement!
Thanks a lot!