Protect what matters – even after you're gone. Make a plan for your digital legacy today.
Forum Discussion
joeRinehart
1 month agoNew Contributor
1Password Chrome extension is incorrectly manipulating <code> blocks
The latest 1Password Chrome extension is incorrectly manipulating the DOM within <code> blocks on static pages. It looks it's using prism.js to try to add syntax highlighting to <code> blocks on the entire page. If you're using a static site generator to highlight code with a different library, it causes the display to break.
Example: mkdocs, a popular documentation tool
If you view the documentation for customizing Mkdocs material (https://squidfunk.github.io/mkdocs-material/customization/) with the extension enabled, you'll see that the YAML example at the top is not highlighted (it should be).
Under the hood, if you inspect its DOM, you can see that it's been rewritten with prismjs classes.
If you disable the extension, it is highlighted:
This is likely to impact a number of documentation sites in the tech community.
Hey everyone! I want to thank everyone who called our attention to this and explain what happened and what we’re doing about it.
What happened: Prism.js is a syntax-highlighting library we use for our Labs Snippets feature. While optimizing our build to reduce bundle size, we unintentionally bundled Prism.js into the extension in a way that caused it to run on pages where it shouldn’t, which interfered with code formatting on certain sites. We apologize for the inconvenience this caused.What we’re doing about it: We’ve completed the fix and submitted it to the Chrome Web Store, along with Firefox, Edge, and our other supported extension storefronts. Rollout timing depends on each store’s review process, but we expect it to land over the next few days.
We want to emphasize that vault security was not impacted. At 1Password, protecting our customers’ privacy, passwords, and credentials is our highest priority.
We’ll be publishing a postmortem covering what went wrong, the timeline, and the concrete changes we’re making to how we build and release future browser extension updates.
52 Replies
- takuyaharaOccasional Contributor
I was looking https://shiki.style/guide/install , an NPM package which provides syntax highlighting and showing detail hovering on keywords. It is expected to be shown and work like this
but is actually shown like this when using a beta or nightly browser extension. There's no issue on normal one.
- OS: macOS 26.2 (25C56)
- Browser: Brave v1.85.111
- jc00keOccasional Contributor
I most recently noticed this when looking at DuckDB docs. Here's an example page https://duckdb.org/docs/stable/sql/query_syntax/select
Extension enabled:
Extension disabled:
Here's a screen recording, you can see the flicker.
Beta 8.11.22.25 in Firefox 146.0.1 on macOS and on Debian/GNOME.
- takuyaharaOccasional Contributor
* Marking this discussion as a solution to close *
1Password team responded on the following discussions and I also received a response from support personally. Their responses are all same "it's known issue and currently investigating" plus "but cannot provide an ETA" on a response I received. And it's not sure if team responds on this discussion when resolved so I close it. Who really needs the issue fixed ASAP might better to use nightly extension which reflects updates the fastest.
Chrome extension breaks client side code snippet rendering
1Password Chrome extension is incorrectly manipulating <code> blocks - solarizdeFrequent Contributor
Another example from my blog:
https://solariz.de/posts/23/force_docker_containers_through_vpn_using_gluetun/
When Enable the 1pass Extension (left screenshot) it modify the code and cause the highlighter not working as before. Extension disabled, right side, works again.- takuyaharaOccasional Contributor