Forum Discussion

chrisk7777's avatar
chrisk7777
New Contributor
10 months ago

Poor deleted items performance; deleted items appearing in search

I believe there are a few bugs with the deleted item flow:

(1) Deleted items appear in search (see screenshots)

Screenshot 1 - An "ebay" item in Deleted. Noting the modification date so we're referring to the same item in the next screenshot

Screenshot 2 - Search for "ebay". Same item appears, incorrectly

(2) Deleted items, that appear in search, can enter into "edit" mode by clicking "edit" in the context menu. However, clicking save on that item doesn't update the item. "Not saving" makes sense, but there is no indication that you are editing a deleted item so data loss is very possible.

Screenshot 3 - I can right click and edit this item. There is no indication I am making edits that won't be saved.

Note: Yes, the deleted item appears grey in the preview panel, however, that makes the assumption that you click the item first. I can right click and edit without seeing the grey panel.

(3) The deleted items functionality is noticeable slower than the rest of the app.
All vaults and items are instant, however, clicking "Recently deleted" I am always presented with a loading screen that takes approximately 30s to load a handful of items.

Screenshot 4 - Constant loading stage

And I think the performance may be the cause of the issues (1) and (2) above.

I suspect because of the slow read access to deleted items they are still being "seen" in search results, and then in turn, I'm getting into an unexpected flow of editing deleted items.

This is reasonably recent, it became noticeable in the last 2 months.

macos

2 Replies

  • chrisk7777's avatar
    chrisk7777
    New Contributor
    9 months ago

    Thanks 1P_Dave - Most of the issues seem related to that upcoming fix you mentioned.

    The fetching from the server explains the lag on deleted items. I'd be interested to know the technical reason why deleted items are treated differently, but its not critical in any way.

    I'll hold off until that fix is released. Is there somewhere where I can follow the rollout for new features? Like a roadmap, etc.

  • 1P_Dave's avatar
    1P_Dave
    Icon for Moderator rankModerator
    9 months ago

    Hello chrisk7777! 👋

    I'm sorry that you're running into issues with deleted items and search. Deleted items appearing in search results is a known issue, the "Other Suggestions" component is incorrectly caching items that have since been archived or deleted. Our developers have already coded a fix for the issue and are testing that fix in the latest beta version of the app. When testing is complete, the fix will be included in the stable version as well.

    (3) The deleted items functionality is noticeable slower than the rest of the app.
    All vaults and items are instant, however, clicking "Recently deleted" I am always presented with a loading screen that takes approximately 30s to load a handful of items.

    Unlike items in other categories which are stored locally on your device, deleted items are fetched each time from the server. Seeing a small delay is normal since the 1Password app is fetching your deleted items and the delay can differ based on the speed of your internet connection.

    That being said, 30 seconds doesn't sound normal. Can you tell me if the loading time is always 30 seconds? And how many deleted items are loaded?

    -Dave

    ref: dev/core/core#34075