Forum Discussion

Anonymous's avatar
Anonymous
3 years ago

APT repo recreated (on update / open)

I'm not sure exactly when this happened, but when updating 1Password through apt, i received messages informing me that the target is configured multiple times. this occurred because I swapped all ...
linux
FrankyO1P's avatar
FrankyO1P
Icon for 1Password Team rank1Password Team
3 years ago

Hi @the456gamer,

Thanks for bringing this to our attention. I'd like to ask, do you need any assistance with resolving the multiple target issue?

I understand you would also like to see a comment included in the sources. I'll go ahead and pass along your feedback and this request to the team.

Looking forward to hearing from you.

roy_orbison's avatar
roy_orbison
Occasional Contributor
7 months ago
--- a/after-install.sh
+++ b/after-install.sh
@@ -20,11 +20,25 @@
   curl -fsSo "$TEMPDIR/1password.pol" https://downloads.1password.com/linux/debian/debsig/1password.pol
 
   # Setup apt repository
-  cp "$TEMPDIR/1password.gpg" /usr/share/keyrings/1password-archive-keyring.gpg
-  cat > /etc/apt/sources.list.d/1password.list <<-EOM
+  KEYRING=/usr/share/keyrings/1password-archive-keyring.gpg
+  cp "$TEMPDIR/1password.gpg" "$KEYRING"
+  LIST=/etc/apt/sources.list.d/1password.list
+  if [ -e "$LIST" ]; then
+    cat > "$LIST" <<- EOM
 # This file is automatically added and configured by the 1Password package. Modifications may be overwritten.
-deb [arch=amd64 signed-by=/usr/share/keyrings/1password-archive-keyring.gpg] https://downloads.1password.com/linux/debian/amd64 ${CHANNEL} main
+deb [arch=amd64 signed-by=${KEYRING}] https://downloads.1password.com/linux/debian/amd64 ${CHANNEL} main
 EOM
+  else
+    cat > "${LIST%.*}.sources" <<- EOM
+Types: deb
+URIs: https://downloads.1password.com/linux/debian/amd64
+Suites: ${CHANNEL}
+Components: main
+Architectures: amd64
+Signed-By: ${KEYRING}
+EOM
+  fi
+
   # Setup debsig verification
   mkdir -p /etc/debsig/policies/AC2D62742012EA22/
   mv "$TEMPDIR/1password.pol" /etc/debsig/policies/AC2D62742012EA22/1password.pol

Here's a backwards-compatible patch for the devs. New installs and systems that already migrated to the .sources format would then get updates without creating conflicts. If the system has both files (the current situation after an update, which causes apt errors), the user need only delete the .list version. If they don't have the .sources version, they can elect to do so using this:

sudo apt modernize-sources

In the extremely unlikely event that someone installs on a Debian-based OS that can run 1Password but doesn't yet accept DEB822 format, they could run this first to force the old format:

sudo touch /etc/apt/sources.list.d/1password.list
  • roy_orbison's avatar
    roy_orbison
    Occasional Contributor
    7 months ago

    Perhaps 1P_Dave​ or someone else active on the Linux tag could look at this. OS upgrades automatically convert .list format files to .sources, so 1P reinstalling the former virtually guarantees it'll break apt updates for the whole machine, including automatic security updates, for every single user of the deb package. Updates cannot run again until one of these files is manually deleted using root privileges, and this whole cycle will likely repeat again. It would be good to see this get higher priority given it's trivial to fix and has a relatively high impact.