Forum Discussion

volts's avatar
volts
Super Contributor
4 years ago

Selection from Keyboard Bug

Here's an odd UI bug:

Select an item in a vault.
Hold Shift and press the Up (or Down) keyboard arrow.
The next item is added to the selection, as expected.

While still holding Shift, press the same Up (or Down) arrow again.
The next item is not added to the selection.

The 3rd and subsequent times work as expected.


1Password Version: 80600077
Extension Version: Not Provided
OS Version: 12.3

16 Replies

  • volts's avatar
    volts
    Super Contributor

    It's much better, thanks!

    There's another weird thing, although it's less likely to happen in normal use.

    • Scroll to the middle of a vault.
    • Select an item.
    • Press & Keep Holding Shift
    • Tap Up, Tap Up, Tap Up (Four items are now selected)
    • Press & Hold Down

    Observation -

    • The selection will first reduce back to the original item, as expected.
    • Then, it will extend to additional items, as expected.
    • But! At some point, the selection will reset back to the original item.

    The reset may happen when 4 items are selected; or when the selection reaches the bottom of the screen; or when Down is released.

    I can make a video if that's helpful.

  • 1P_Rob's avatar
    1P_Rob
    Icon for 1Password Team rank1Password Team

    Hey volts. This has been fixed in the latest nightly (80700019). Thanks again for the report!

  • volts's avatar
    volts
    Super Contributor

    I'm easily entertained!
    And thank you for the investigation and sharing the details here. Appreciated.

  • 1P_Rob's avatar
    1P_Rob
    Icon for 1Password Team rank1Password Team

    Yep! I noticed that as well. Here's another one to entertain you:

    1. Select an item.
    2. Press Shift+Down.
    3. Press Shift+Up.

    It should go back to just one item selected, but it actually jumps and selects the original item and the one above it. Same thing happens in reverse.

    Anyway, I just spent the last 90 minutes testing and locating the problem, then writing it up for the team. It turned out to be a weird race condition where we lose track of the most recently selected item when going from 1 to 2 selected items. This just started with a change that was made a couple months ago to improve something else. I have a few ideas for how to fix it, so we just need to decide on the best way and get it done.

    Thanks again for the report!

  • volts's avatar
    volts
    Super Contributor

    :-)

    Thanks! It felt weird, and because pressing Up an additional time worked, I didn't really understand at first.

    Try this too -

    Select an item
    Hold Shift and press Up a handful of times, to select a few more items
    Then (still holding Shift) press Down to select fewer items
    Keep going down, past the original item ...

    It will do the same "Pause at two" thing as you pass the first item selected. It's not "The 2nd time you press Up", it's "When there are 2 selected".

  • 1P_Rob's avatar
    1P_Rob
    Icon for 1Password Team rank1Password Team

    Huh. That's very interesting, volts. Thanks for the report! I've filed an issue and will see if I can look into it myself. It's exactly the kind of annoying little logic bug I enjoy sniffing out. :D

    ref: dev/core/core#13532