Forum Discussion

milad's avatar
milad
Occasional Contributor
4 years ago

1password hijacks control+minus keybinding

I noticed that my ctrl+- keybindings stop working when 1password is running.

Output of xev when 1password is not running and I press ctrl+minus:

```
KeyPress event, serial 34, synthetic NO, window 0x2000001,
root 0x214, subw 0x0, time 16255124, (348,375), root:(2288,405),
state 0x0, keycode 37 (keysym 0xffe3, Control_L), same_screen YES,
XLookupString gives 0 bytes:
XmbLookupString gives 0 bytes:
XFilterEvent returns: False

KeyPress event, serial 34, synthetic NO, window 0x2000001,
root 0x214, subw 0x0, time 16255311, (348,375), root:(2288,405),
state 0x4, keycode 20 (keysym 0x2d, minus), same_screen YES,
XLookupString gives 1 bytes: (2d) "-"
XmbLookupString gives 1 bytes: (2d) "-"
XFilterEvent returns: False
```

and when 1password is running in the background:

```
KeyPress event, serial 34, synthetic NO, window 0x5e00001,
root 0x214, subw 0x0, time 16378924, (1122,912), root:(3062,942),
state 0x0, keycode 37 (keysym 0xffe3, Control_L), same_screen YES,
XLookupString gives 0 bytes:
XmbLookupString gives 0 bytes:
XFilterEvent returns: False

FocusOut event, serial 34, synthetic NO, window 0x5e00001,
mode NotifyGrab, detail NotifyAncestor

FocusOut event, serial 34, synthetic NO, window 0x5e00001,
mode NotifyUngrab, detail NotifyPointer

FocusIn event, serial 34, synthetic NO, window 0x5e00001,
mode NotifyUngrab, detail NotifyAncestor

KeymapNotify event, serial 34, synthetic NO, window 0x0,
keys: 2 0 0 0 32 0 0 0 0 0 0 0 0 0 0 0

0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

```

I do not have that keybinding configured in 1password settings so to me this looks like a bug.

1Password Version: 8.4.0
Extension Version: Not Provided
OS Version: linux 5.10

linux

9 Replies

  • milad's avatar
    milad
    Occasional Contributor
    4 years ago

    I have a few electron apps and 1password is the only one affected by this. :(

  • Mathieu_1P's avatar
    Mathieu_1P
    Icon for 1Password Team rank1Password Team
    4 years ago

    Sorry about that response delay milad, I've been on vacation and missed my notifications. I don't know if any team members are dedicated to this effort at the moment. This issue does seem to originate in the upstream electron code so it may take a little longer than some other bugs to get a fix into stable. I'm really sorry about the inconvenience.

  • milad's avatar
    milad
    Occasional Contributor
    4 years ago

    Are there any updates on this bug? This still happens as of 8.7.0

  • Mathieu_1P's avatar
    Mathieu_1P
    Icon for 1Password Team rank1Password Team
    4 years ago

    Thank you for trying that out Milad. The keyboard layout does seem quite relevant. If I'm not mistaken, the \ shares a physical key with - on that keyboard layout which would suggest this is another manifestation of a bug we are tracking internally for keyboard shortcuts. I can't say how quickly we are going to address this specific issue but we will hopefully get some time to fix it soon.

  • milad's avatar
    milad
    Occasional Contributor
    4 years ago

    That does make the problem go away! In fact Ctrl+\ seems to be the culprit here. If I add that keybinding to any action it hijacks Ctrl+- but without it other keybindings are fine.

    btw I'm using an ISO (i.e. European) keyboard layout if that's relevant. My keyboard layout is configured with setxkbmap gb,ir -option 'grp:rctrl_rshift_toggle'

  • Mathieu_1P's avatar
    Mathieu_1P
    Icon for 1Password Team rank1Password Team
    4 years ago

    Thanks for that information Milad, I'll dig into this a bit today and see if my colleagues have any ideas. I did forget to list another item which may be useful in this case, would you mind telling me what keyboard layout you use?

    Also, could you try clearing all those keyboard shortcuts and see if the problem still happens then?

  • milad's avatar
    milad
    Occasional Contributor
    4 years ago

    Thanks Mathieu!

    Sure, I'm using:
    * Arch linux with kernel 5.10.80
    * i3 window manager on Xorg
    * no wayland
    * nvidia GPU
    * CPU AMD Ryzen 5

  • Mathieu_1P's avatar
    Mathieu_1P
    Icon for 1Password Team rank1Password Team
    4 years ago

    Thanks for writing in milad.

    This definitely should not be happening. Would it be possible to provide a little more information about your system to help us track down what is happening here? The most useful information that comes to mind is;
    - distribution (ex. Debian, Ubuntu, Fedora, Arch, ...) and it's version.
    - desktop environment (ex. Gnome, KDE, XFCE, ...)
    - are you running with xwayland
    - what processor architecture are you using